Skip to content

fix: Remove the toLowerCase in translator to allow lang code like "zh-CN"#732

Merged
MaxRobinsonTheGreat merged 1 commit intomindcraft-bots:developfrom
gaogzs:develop
Mar 19, 2026
Merged

fix: Remove the toLowerCase in translator to allow lang code like "zh-CN"#732
MaxRobinsonTheGreat merged 1 commit intomindcraft-bots:developfrom
gaogzs:develop

Conversation

@gaogzs
Copy link
Copy Markdown
Contributor

@gaogzs gaogzs commented Mar 10, 2026

Otherwise the api would not recognise the language codes containing upper case letters.

@gaogzs gaogzs changed the title Remove the toLowerCase in translator to allow lang code like "zh-CN" fix: Remove the toLowerCase in translator to allow lang code like "zh-CN" Mar 10, 2026
Copy link
Copy Markdown
Contributor

@uukelele uukelele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MaxRobinsonTheGreat MaxRobinsonTheGreat merged commit 98303da into mindcraft-bots:develop Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants